[sldev] Am I missing something ...

Felix Duesenburg kfa at gmx.net
Fri May 30 10:08:09 PDT 2008


I know a similar instance, see llstartup.cpp line 1271:

gSavedSettings.setBOOL("LoginLastLocation",gSavedSettings.getBOOL("LoginLastLocation"));

I ran into it when making the patch for VWR-1422, where I had to replace 
the boolean setting with a string to allow for the 3rd choice, logging 
in at a favourite location. I didn't know what to do with that line and 
actually preserved it (with the new name) to avoid breaking anything. I 
remember guessing that it could be there to set a kind of 'dirty' flag 
to make sure a certain setting gets written out when the save method is 
called. But I didn't investigate whether that was so and what purpose it 
would serve, and then forgot about it.

Felix


Phoenix wrote:
> 
> On 2008-05-30, at 03:13, Aimee Walton wrote:
>> Can anyone explain a good reason for this to me ...
>>
>>         mLastShowParcelOwners = 
>> gSavedSettings.getBOOL("ShowParcelOwners");
>>         gSavedSettings.setBOOL("ShowParcelOwners", 
>> mLastShowParcelOwners);
>>
>> Happens in lltoolbrush.cpp and lltoolselectland.cpp when selecting or 
>> deselecting the tool. Is that as pointless as it looks, or is there 
>> some intended side effect I'm missing? Commented out all references to 
>> mLastShowParcelOwners and seems to have no noticeable effect, it's not 
>> used for anything else.
> 
> According to an engineer here:
> 
> "I took a look at the code all of the references to 
> mLastShowParcelOwners and it certainly looks vestigal.
> I'm going to remove it."
> 
> Thanks Aimee, and good catch. :)
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Click here to unsubscribe or manage your list subscription:
> /index.html



More information about the SLDev mailing list