[sldev] llfilepicker.h problem

Alissa Sabre alissa_sabre at yahoo.co.jp
Wed Nov 12 00:10:49 PST 2008


> I'm trying to add this feature :
> http://jira.secondlife.com/browse/VWR-5206

I have no concern on the feature, and I have no opinion whether we support
it, but,

> When i'm trying to include llfilepicker.h into the lltexteditor.cpp
> inside
> llui.

I don't believe this is a good idea.  That is, llui/lltexteditor.cpp should
never include newview/llfilepicker.h.  It is primarily to keep isolation of
the purpose of the codes in each directory clearly.

I suggest either

Move llfilepicker.{h,cpp} to llui/ (or to llwindow/), modifying its API
slightly to match where they now belong, and include the new
llui/llfilepicker.h.

or

Define some hook/callback mechanism in LLTextEditor, some module under
newview/ directory defines an appropriate callback routine, and let that
routine show LLFIlePicker when it is called back from LLTextEditor. 

Alissa Sabre


--------------------------------------
Power up the Internet with Yahoo! Toolbar.
http://pr.mail.yahoo.co.jp/toolbar/


More information about the SLDev mailing list