[sldev] [PATCH] VWR-12758, can not find tut/tut.hpp
Robin Cornelius
robin.cornelius at gmail.com
Tue Apr 14 11:55:54 PDT 2009
Sorry if this appears twice/first copy gets held for moderation. I sent
it from the wrong email address which is not subscribed to sldev.....
Hey Guys,
Right i was suppose to raise this on sldev after Rob's hour last
Thursday, but with easter and all,... here we are. I'm now not happy
with the patch, and some further self review has opened some questions:-
Firstly, on http-texture tut is a build dependency and the build fails
ungracefully if its not found. I believe all non trivial build
dependencies should be tested for and error out at the configure stage
if they are not found. This is what the current patch does. What the
patch also does is attempt to find tut.h in either /usr/include or
/usr/local/include. Now this is pointless as i'm not using the output
variable TUT_INCLUDE_DIR in anyway and those folders are the implicit
default search folders anyway. That said if you are going to go to the
bother of checking the presence of a critical file, it makes sense to
cache its location just in case some other code needs it.
The original bug description of VWR-12578 had an issue when the tut
headers were placed with in the linden include dirs when doing a
standalone build which is not a supported configuration, on standalone
tut.h and friends need to be in /usr/include/ or /usr/local/include/ My
patch does not actually address that but just does a check that tut.h is
present in a system searched location that would ensure its usable for
build.
Any comments or views on this?
Thanks
Robin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
Url : http://lists.secondlife.com/pipermail/sldev/attachments/20090414/08d9da10/attachment.pgp
More information about the SLDev
mailing list