[sldev] Request review of VWR-13251 Revise lscript_library.cppto allow localization of LSL editor hovertips
Soft
soft at lindenlab.com
Wed May 6 13:22:38 PDT 2009
On Wed, May 6, 2009 at 3:17 PM, Mike Monkowski <monkowsk at watson.ibm.com> wrote:
> Soft wrote:
>>
>> If you can't build yourself, we should be able
>> to kick off a new build of the branch after I get the okay to commit.
>
> But doesn't the review come *before* the commit?
In the full context, that was about the test plan, not the code
review. Internally, the test plan is reviewed before the commit, by
the same people who do code is reviews. Then, the approved test plan
is executed by QA after the commit.
It's a good question whether we use that same process in the open
source branch. Suggestions?
More information about the SLDev
mailing list