[sldev] -Werror (was: Notes from a Mac Build)

[Lillian Yiyuan]

-Werror is supplied by the make files. This too involves changing
code, and is a bad idea in open source, since it gets people to check
problems before submitting them as patches.

Better here, I think, would be to make this opaque, rather than having
constant strings in cpp files that the code hands out char * to.

The compiler is right here, this is a bad idea, and it should be fixed
rather than swept under the rug.



On Wed, Nov 4, 2009 at 6:52 AM, Boroondas Gupte
<sllists at boroon.dasgupta.ch> wrote:
> Lillian Yiyuan wrote:
>> You can tell the nice people developing the gcc that they made a
>> mistake enforcing type checking then. However, you've provided no
>> evidence that your position is based on any kind of knowledge.
>>
>> On Wed, Nov 4, 2009 at 5:55 AM, Argent Stonecutter
>> <secret.argent at gmail.com> wrote:
>>
>>> Which is why it should be left as a *warning* until someone actually
>>> traces down what the correct fix is, rather than hiding it or creating
>>> a memory leak.
> g++-4.4.x by default only warns about it. It's the -Werror option that
> turns the warning (all enabled warnings, actually) into an error.
> -Werror is useful to ensure the code compiles without any warnings at
> all. Though, as here, it might cause a project stop building when the
> compiler changes what it warns about by default and the new default
> warning isn't disabled manually.
>
> Unfortunately, there doesn't seem to be a way to exclude only specific
> warnings from becoming fatal and still have them displayed as warnings,
> so if you cannot fix the code, either removing -Werror or turning off
> the warning are probably your only options.
>
> Boroondas
>