[sldev] VWR-15310 - Fixing "Save to XML" (Re: Snowglobe 1.2 status)

[Philippe (Merov) Bossut]

Hi,

Did a review. +1. See JIRA for details.

Cheers,
- Merov

On Tue, Sep 29, 2009 at 7:26 AM, Mike Monkowski
<monkowsk at fishkill.ibm.com>wrote:

> Are there any official committers out there willing to review this
> patch?  It looks like a lot of changes, but it's really just repeats of
> the same type of changes in many derived classes.  Admiral Admiral wrote
> the code and I have reviewed it, but I'm not an official committer.
>
> Mike
>
> Rob Lanphier wrote:
> > On Wed, Sep 23, 2009 at 10:08 AM, Mike Monkowski
> > <monkowsk at fishkill.ibm.com <mailto:monkowsk at fishkill.ibm.com>> wrote:
> >
> >     Admiral Admiral and I have requested that the bug fix at
> >     http://jira.secondlife.com/browse/VWR-15310
> >     "Advanced->XUI->Save to XML doesn't set proper XML tags"
> >     be considered for inclusion.  Is it still under consideration?
> >     Rejected?  Ignored?
> >
> >
> >
> > This adds a lot of code, but I suppose if we're going to have a feature
> > in the product, we should make sure the silly thing works. If you can
> > find a Snowglobe committer who is willing to review the code carefully
> > for general impact, I don't see any reason not to include this.
> >
> >
> >
> >     We would prefer that it go into the standard viewer, but because of
> >     a comment added to the issue, "This would be good to fire up a
> >     conversation on sldev@ about for possible inclusion in Snowglobe" it
> >     gets bypassed by the Bug Triage meetings.
> >
> >
> > Yup, thanks for doing that.
> >
> > Thanks
> > Rob
>
> _______________________________________________
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/SLDev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/sldev/attachments/20090930/62e6ec20/attachment.htm