[opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

[Thickbrick Sleaford]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/2/#review13
-----------------------------------------------------------



indra/newview/llappviewer.cpp
<http://codereview.secondlife.com/r/2/#comment7>

    Somewhat tangential to this patch: this line is wrong. It should use gFrameIntervalSeconds, not gFarmeTimeSeconds. As it is, max_idle_time will always be clamped to 0.005.
    
    The comment is also wrong/outdated. It should be something like "50 ms/second, up to 5 ms/frame."


- Thickbrick


On 2010-12-01 19:57:24, Oz Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/2/
> -----------------------------------------------------------
> 
> (Updated 2010-12-01 19:57:24)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This review is mostly a first test of reviewboard.
> 
> I do have an esthetic dislike for the 'break' statement anywhere but as the end of a case, so I chose to change some instances of break usage that were not justified by any extreme need.
> 
> 
> This addresses bug storm-606.
>     http://jira.secondlife.com/browse/storm-606
> 
> 
> Diffs
> -----
> 
>   indra/newview/llappviewer.cpp bf98b026bcb1 
> 
> Diff: http://codereview.secondlife.com/r/2/diff
> 
> 
> Testing
> -------
> 
> None at all... have not even compiled it yet.
> 
> 
> Thanks,
> 
> Oz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101202/7b248f87/attachment.htm