[opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

Gigs gigstaggart at gmail.com
Thu Dec 2 12:05:05 PST 2010


I'm getting "To protect your privacy, Thunderbird has blocked remote 
content."   Why do the message include external images?  As well because 
the "From" field is a person and not the list, I would have to whitelist 
every contributor to get rid of the message.

On 12/02/2010 12:05 PM, Thickbrick Sleaford wrote:
>
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/2/
>
>
> indra/newview/llappviewer.cpp
> <http://codereview.secondlife.com/r/2/diff/1/?file=8#file8line1184>
> (Diff revision 1)
>
> bool LLAppViewer::mainLoop()
>
> 1184 	
>
> 				const  F64  max_idle_time  =  llmin(.005*10.0*gFrameTimeSeconds,  0.005);  // 5 ms a second
>
> 	1184 	
>
> 				const  F64  max_idle_time  =  llmin(.005*10.0*gFrameTimeSeconds,  0.005);  // 5 ms a second
>
> Somewhat tangential to this patch: this line is wrong. It should use gFrameIntervalSeconds, not gFarmeTimeSeconds. As it is, max_idle_time will always be clamped to 0.005.
>
> The comment is also wrong/outdated. It should be something like"50 ms/second, up to 5 ms/frame."
>
>
> - Thickbrick
>
>
> On December 1st, 2010, 7:57 p.m., Oz Linden wrote:
>
> Review request for Viewer.
> By Oz Linden.
>
> /Updated 2010-12-01 19:57:24/
>
>
>   Description
>
> This review is mostly a first test of reviewboard.
>
> I do have an esthetic dislike for the'break'  statement anywhere but as the end of a case, so I chose to change some instances of break usage that were not justified by any extreme need.
>
>
>   Testing
>
> None at all... have not even compiled it yet.
>
> *Bugs: * storm-606 <http://jira.secondlife.com/browse/storm-606>
>
>
>   Diffs
>
>     * indra/newview/llappviewer.cpp (bf98b026bcb1)
>
> View Diff <http://codereview.secondlife.com/r/2/diff/>
>
>
>
> _______________________________________________
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges



More information about the opensource-dev mailing list