[opensource-dev] Review Request: STORM-34 As a User, I want a list of my favorite locations available on the login screen so i can log in to SL right where I want to be.

[Cron Stardust]

> On 2010-12-06 08:33:21, Seth ProductEngine wrote:
> > Looks good for a first version of the task implementation, considering the issues mentioned in the description.

Agreed.  The code looks clean. (As expected from the pro's! :D )  Thought I had found a style issue, but double checked the style guide (no guidance found there,) and then checked similar code and found the same style.  So no problem. :)


- Cron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/4/#review14
-----------------------------------------------------------


On 2010-12-06 08:00:40, Andrew ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/4/
> -----------------------------------------------------------
> 
> (Updated 2010-12-06 08:00:40)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Saving of user's favorites into file and showing them in "Start at" combobox on login screen was implemented.
> 
> 
> Implementation details:
> 
> - File is saved on exit from viewer and not immediately on changes as was written in spec. It is done to make this file consistent with favorites order: order of favorites is saved on exit,
> so if favorites info is saved in other moment earlier, crashing viewer or other unexpected way of finishing its work (i.e. via Windows task bar) would cause inconsistence between favorites order
> saved per account and one from this new file.
> 
> - File is saved in user_settings\stored_favorites.xml.
> 
> - If you uncheck the option in Preferences and press OK, the file gets immediately deleted (according to spec).
> 
> 
> Issues that require further changes:
> 
> - Currently only favorites of last logged in user are shown in login screen. Showing favorites of multiple users will be implemented later when design for it is approved by Esbee.
> 
> - Preference is now global for all users, because design states it may be changed before login, and we don't have account info at the moment. But it doesn't seem to be a good idea, so changes in design are needed.
> 
> - Currently the way of retrieving SLURLs needs optimization in a separate ticket.
> 
> More detailed design approved by Esbee is needed to develop it further, perhaps in new tickets.
> 
> 
> This addresses bug storm-34.
>     http://jira.secondlife.com/browse/storm-34
> 
> 
> Diffs
> -----
> 
>   indra/newview/app_settings/settings.xml e843e274fa58 
>   indra/newview/llfavoritesbar.cpp e843e274fa58 
>   indra/newview/llfloaterpreference.h e843e274fa58 
>   indra/newview/llfloaterpreference.cpp e843e274fa58 
>   indra/newview/llpanellogin.h e843e274fa58 
>   indra/newview/llpanellogin.cpp e843e274fa58 
>   indra/newview/llviewerinventory.cpp e843e274fa58 
>   indra/newview/skins/default/xui/en/notifications.xml e843e274fa58 
>   indra/newview/skins/default/xui/en/panel_preferences_privacy.xml e843e274fa58 
> 
> Diff: http://codereview.secondlife.com/r/4/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101208/25888978/attachment.htm