[opensource-dev] Review Request: Crash in LLVivoxVoiceClient::notifyStatusObservers()

[Merov Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/25/#review38
-----------------------------------------------------------

Ship it!


This looks correct to me and should fix the observed crasher.

- Merov


On 2010-12-15 11:48:39, Kitty Barnett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/25/
> -----------------------------------------------------------
> 
> (Updated 2010-12-15 11:48:39)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Moved removeObserver() out of the "if(getAvatarId().notNull()) { }" block since "getAvatarId()" can return the NULL UUID (i.e. if the panel hasn't been opened), matching the addObserver() without condition in postBuild.
> 
> 
> This addresses bug VWR-24209.
>     http://jira.secondlife.com/browse/VWR-24209
> 
> 
> Diffs
> -----
> 
>   indra/newview/llpanelavatar.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/25/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kitty
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101216/104cf2cf/attachment.htm