[opensource-dev] Review Request: Crash in LLVivoxVoiceClient::notifyStatusObservers()

Kitty Barnett sldev at catznip.com
Wed Dec 15 11:48:39 PST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/25/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

Moved removeObserver() out of the "if(getAvatarId().notNull()) { }" block since "getAvatarId()" can return the NULL UUID (i.e. if the panel hasn't been opened), matching the addObserver() without condition in postBuild.


This addresses bug VWR-24209.
    http://jira.secondlife.com/browse/VWR-24209


Diffs
-----

  indra/newview/llpanelavatar.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/25/diff


Testing
-------


Thanks,

Kitty

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101215/ea43a047/attachment.htm 


More information about the opensource-dev mailing list