[opensource-dev] Review Request: Crash in LLRemoteParcelInfoProcessor::processParcelInfoReply()

[Kitty Barnett]

> On 2010-12-16 11:11:33, Kitty Barnett wrote:
> > *confuzzled*

Does it want an incremental change starting at the previous diff? Or a diff that includes the original diff (starting from viewer-dev)?
> 
> Aleric Inglewood wrote:
>     When I click on the link 'Diff r2', I don't get a diff - I get an error message that 2 our of 5 hunks failed to apply.
>

I know :|. 

That's why I asked if "update diff" wants an incremental diff (changes against the original diff), or a full diff (changes against viewer-development), or something else entirely?


- Kitty


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/24/#review42
-----------------------------------------------------------


On 2010-12-16 11:06:44, Kitty Barnett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/24/
> -----------------------------------------------------------
> 
> (Updated 2010-12-16 11:06:44)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> erase() on a multimap will only invalidate iterators that point to the element being erased so pre-incrementing the loop iterator should prevent it from getting invalidated when an observer calls removeObserver() as part of its processParcelInfo() implementation.
> 
> 
> This addresses bug VWR-24207.
>     http://jira.secondlife.com/browse/VWR-24207
> 
> 
> Diffs
> -----
> 
>   indra/newview/llremoteparcelrequest.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/24/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kitty
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101217/b2868250/attachment.htm