[opensource-dev] Review Request: VWR-24254: Add support for using ld.gold on linux.

[Aleric Inglewood]

> On 2010-12-19 11:07:57, Boroondas Gupte wrote:
> > indra/cmake/LLCommon.cmake, line 11
> > <http://codereview.secondlife.com/r/48/diff/1/?file=113#file113line11>
> >
> >     Is this removal related to ld.gold, too, or just general cleanup?

Oops. That was supposed to be a general cleanup, inspired by the fact that llcommon isn't including apu.h (the header that is being looked for for APRUTIL_INCLUDE_DIR). But because of your question I double checked, and although /usr/include/apr-1.0 contains
apr_*.h files and apu_*.h files, about half of the apr_*.h files belong to aprutil! And we DO use those (ie, apr_base64.h).
I'll change the patch to not remove that tomorrow.


- Aleric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/48/#review52
-----------------------------------------------------------


On 2010-12-19 09:42:53, Aleric Inglewood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/48/
> -----------------------------------------------------------
> 
> (Updated 2010-12-19 09:42:53)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> To use ld.gold configure with:
>   -DCMAKE_EXE_LINKER_FLAGS:STRING="-Wl,-use-gold".
> 
> See VWR-24254 for more details.
> 
> 
> This addresses bug VWR-24254.
>     http://jira.secondlife.com/browse/VWR-24254
> 
> 
> Diffs
> -----
> 
>   indra/cmake/BerkeleyDB.cmake b0689af42a71 
>   indra/cmake/LLCommon.cmake b0689af42a71 
>   indra/cmake/LLPlugin.cmake b0689af42a71 
>   indra/llwindow/CMakeLists.txt b0689af42a71 
> 
> Diff: http://codereview.secondlife.com/r/48/diff
> 
> 
> Testing
> -------
> 
> ld.gold links the viewer on my machine in 8 seconds, as
> opposed to 19 seconds with ld.bfd. Moreover, it uses a
> LOT less memory during linking (about 750 MB instead of
> 2.5 GB! (for viewer 1)).
> 
> Since my machine locked up hard when I run out of memory
> (something with using an encrypted RAID for my swap),
> and compiling viewer 2 uses more than 3 GB, I couldn't
> compile viewer 2 at all anymore without this patch (and
> using ld.gold). And OMG this is fast!
> 
> 
> Thanks,
> 
> Aleric
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101220/47e4968b/attachment-0001.htm