[opensource-dev] Review Request: VWR-24254: Add support for using ld.gold on linux.

[Aleric Inglewood]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/48/
-----------------------------------------------------------

(Updated 2010-12-21 07:59:33.568556)


Review request for Viewer.


Changes
-------

Attached an incremental diff that reverts the removal of APRUTIL_INCLUDE_DIR


Summary
-------

To use ld.gold configure with:
  -DCMAKE_EXE_LINKER_FLAGS:STRING="-Wl,-use-gold".

See VWR-24254 for more details.


This addresses bug VWR-24254.
    http://jira.secondlife.com/browse/VWR-24254


Diffs (updated)
-----

  indra/cmake/LLCommon.cmake b0689af42a71 

Diff: http://codereview.secondlife.com/r/48/diff


Testing
-------

ld.gold links the viewer on my machine in 8 seconds, as
opposed to 19 seconds with ld.bfd. Moreover, it uses a
LOT less memory during linking (about 750 MB instead of
2.5 GB! (for viewer 1)).

Since my machine locked up hard when I run out of memory
(something with using an encrypted RAID for my swap),
and compiling viewer 2 uses more than 3 GB, I couldn't
compile viewer 2 at all anymore without this patch (and
using ld.gold). And OMG this is fast!


Thanks,

Aleric

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101221/fc9a915d/attachment.htm