[opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

[Merov Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/63/
-----------------------------------------------------------

(Updated 2010-12-24 11:46:22.693285)


Review request for Viewer.


Changes
-------

Took comments into account and some more:
- Reverted making methods public to protected. Actually, I even made some methods private as they should.
- Declared some public methods in the derived test class to test the protected methods
- Fixed code so assert() work in debug mode (stub empty class was too inconsistent)
- Moved one generic function out of llimagej2coj to clean things up there


Summary
-------

Unit tests addition:
- add tests for llkdu
- turned back on and fix unit tests for llimage
- turned back on and fix unit tests for llworldmap and llworldmipmap


This addresses bug STORM-744.
    http://jira.secondlife.com/browse/STORM-744


Diffs (updated)
-----

  indra/llimage/CMakeLists.txt 279f35982a1a 
  indra/llimage/tests/llimageworker_test.cpp 279f35982a1a 
  indra/llimagej2coj/llimagej2coj.h 279f35982a1a 
  indra/llimagej2coj/llimagej2coj.cpp 279f35982a1a 
  indra/llkdu/CMakeLists.txt 279f35982a1a 
  indra/llkdu/llimagej2ckdu.h 279f35982a1a 
  indra/llkdu/llimagej2ckdu.cpp 279f35982a1a 
  indra/llkdu/tests/llimagej2ckdu_test.cpp PRE-CREATION 
  indra/newview/CMakeLists.txt 279f35982a1a 
  indra/newview/tests/llworldmap_test.cpp 279f35982a1a 
  indra/newview/tests/llworldmipmap_test.cpp 279f35982a1a 

Diff: http://codereview.secondlife.com/r/63/diff


Testing
-------


Thanks,

Merov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101224/bc6ebb13/attachment.htm