[opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/63/#review94
-----------------------------------------------------------


Thanks, Merov. I have no more objections.


indra/llimagej2coj/llimagej2coj.cpp
<http://codereview.secondlife.com/r/63/#comment68>

    Please add the "static" modifier to indicate that the function is not supposed to be used outside of the file.


- Vadim


On 2010-12-24 11:46:22, Merov Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/63/
> -----------------------------------------------------------
> 
> (Updated 2010-12-24 11:46:22)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Unit tests addition:
> - add tests for llkdu
> - turned back on and fix unit tests for llimage
> - turned back on and fix unit tests for llworldmap and llworldmipmap
> 
> 
> This addresses bug STORM-744.
>     http://jira.secondlife.com/browse/STORM-744
> 
> 
> Diffs
> -----
> 
>   indra/llimage/CMakeLists.txt 279f35982a1a 
>   indra/llimage/tests/llimageworker_test.cpp 279f35982a1a 
>   indra/llimagej2coj/llimagej2coj.h 279f35982a1a 
>   indra/llimagej2coj/llimagej2coj.cpp 279f35982a1a 
>   indra/llkdu/CMakeLists.txt 279f35982a1a 
>   indra/llkdu/llimagej2ckdu.h 279f35982a1a 
>   indra/llkdu/llimagej2ckdu.cpp 279f35982a1a 
>   indra/llkdu/tests/llimagej2ckdu_test.cpp PRE-CREATION 
>   indra/newview/CMakeLists.txt 279f35982a1a 
>   indra/newview/tests/llworldmap_test.cpp 279f35982a1a 
>   indra/newview/tests/llworldmipmap_test.cpp 279f35982a1a 
> 
> Diff: http://codereview.secondlife.com/r/63/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Merov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101227/195d3bb6/attachment-0001.htm