[opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent
Jonathan Yap
jhwelch at gmail.com
Fri Dec 24 15:30:54 PST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/65/#review89
-----------------------------------------------------------
indra/newview/llpanelmaininventory.cpp
<http://codereview.secondlife.com/r/65/#comment63>
I updated the code per Aleric's suggestion but the 2nd diff failed to upload. There must be some unusual hg command to generate follow-up diffs in a format RB will be happy with. You can see the change on bitbucket though.
- Jonathan
On 2010-12-23 13:25:31, Jonathan Yap wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/65/
> -----------------------------------------------------------
>
> (Updated 2010-12-23 13:25:31)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> This change enables the "+" menu in Inventory/Recent
> It grays out "New Folder" in this menu
> It enables identical menu entries when you right click on an inventory item.
>
> Question:
> Is graying out "New Folder" best done where I am doing it now -- in
> llpanelmaininventory.cpp / LLPanelMainInventory::onAddButtonClick()
>
>
> This addresses bug storm-737.
> http://jira.secondlife.com/browse/storm-737
>
>
> Diffs
> -----
>
> doc/contributions.txt e843e274fa58
> indra/newview/llinventorybridge.cpp e843e274fa58
> indra/newview/llpanelmaininventory.cpp e843e274fa58
>
> Diff: http://codereview.secondlife.com/r/65/diff
>
>
> Testing
> -------
>
> I opened up Inventory/My Inventory and used all the "New xxx" options for both right clicking on an inventory item and also from the "+" menu.
>
> I then changed to the Recent tab and performed the same steps.
>
> New items were created as expected, except "New Folder" was not an option via either method when the Recent tab was active.
>
>
> Thanks,
>
> Jonathan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101224/de463092/attachment-0001.htm
More information about the opensource-dev
mailing list