[opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

[Oz Linden]

> On 2010-12-24 13:25:16, Aleric Inglewood wrote:
> >

I'm going to respectfully disagree with Aleric on one minor style point.  When comparing equality between a literal or constant and a variable, putting the constant value has an advantage:  it avoids the "=" vs "==" error:

if (FOO_LIMIT == foo_counter) 

works just fine, but produces a syntax error if you mistype and leave off one of the "=", where:

if (foo_counter = FOO_LIMIT)

compiles just fine because = is an operator that returns the assigned value, and C/C++ treats any value as valid for true/false.  Occasionally, this is handy, but if what you wanted was comparison, it's a hard-to-spot bug.


- Oz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/65/#review88
-----------------------------------------------------------


On 2010-12-23 13:25:31, Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/65/
> -----------------------------------------------------------
> 
> (Updated 2010-12-23 13:25:31)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This change enables the "+" menu in Inventory/Recent
> It grays out "New Folder" in this menu
> It enables identical menu entries when you right click on an inventory item.
> 
> Question:
>  Is graying out "New Folder" best done where I am doing it now -- in 
> llpanelmaininventory.cpp / LLPanelMainInventory::onAddButtonClick()
> 
> 
> This addresses bug storm-737.
>     http://jira.secondlife.com/browse/storm-737
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt e843e274fa58 
>   indra/newview/llinventorybridge.cpp e843e274fa58 
>   indra/newview/llpanelmaininventory.cpp e843e274fa58 
> 
> Diff: http://codereview.secondlife.com/r/65/diff
> 
> 
> Testing
> -------
> 
> I opened up Inventory/My Inventory and used all the "New xxx" options for both right clicking on an inventory item and also from the "+" menu.
> 
> I then changed to the Recent tab and performed the same steps.
> 
> New items were created as expected, except "New Folder" was not an option via either method when the Recent tab was active.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101227/e6cef185/attachment-0001.htm