[opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

[Merov Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/63/
-----------------------------------------------------------

(Updated 2010-12-28 22:45:28.345670)


Review request for Viewer.


Changes
-------

Here's a new diff that changes a bit the llimagej2ckdu.cpp code so that it works consistently for unit tests on all build options on all platforms. I added extra comments in the llimagej2ckdu_test.cpp to explain the result.
Clearly, we also need to create integration tests for this but that should be another JIRA.


Summary
-------

Unit tests addition:
- add tests for llkdu
- turned back on and fix unit tests for llimage
- turned back on and fix unit tests for llworldmap and llworldmipmap


This addresses bug STORM-744.
    http://jira.secondlife.com/browse/STORM-744


Diffs (updated)
-----

  indra/llimage/CMakeLists.txt 43cf4a37774c 
  indra/llimage/tests/llimageworker_test.cpp 43cf4a37774c 
  indra/llimagej2coj/llimagej2coj.h 43cf4a37774c 
  indra/llimagej2coj/llimagej2coj.cpp 43cf4a37774c 
  indra/llkdu/CMakeLists.txt 43cf4a37774c 
  indra/llkdu/llimagej2ckdu.h 43cf4a37774c 
  indra/llkdu/llimagej2ckdu.cpp 43cf4a37774c 
  indra/llkdu/tests/llimagej2ckdu_test.cpp PRE-CREATION 
  indra/newview/CMakeLists.txt 43cf4a37774c 
  indra/newview/tests/llworldmap_test.cpp 43cf4a37774c 
  indra/newview/tests/llworldmipmap_test.cpp 43cf4a37774c 

Diff: http://codereview.secondlife.com/r/63/diff


Testing
-------


Thanks,

Merov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101229/14403c09/attachment-0001.htm