[opensource-dev] Review Request: (STORM-797) Parcel SLURL rendering

[Andrew ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/69/#review106
-----------------------------------------------------------

Ship it!


Looks plausible. The fix works good, and though some changes may not look pretty, I can't offer a better way to do them.

- Andrew


On 2010-12-30 08:20:11, Seth ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/69/
> -----------------------------------------------------------
> 
> (Updated 2010-12-30 08:20:11)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Added parcel SLURL rendering with human readable parcel names.
> - Added parcel info observer to LLUrlEntryParcel.
> - Added notifying LLUrlEntryParcel by LLRemoteParcelInfoProcessor when parcel data arrives.
> - Added notifying LLUrlEntryParcel about user login, changing host and viewer connection state to use this data in remote parcel requests.
> 
> 
> This addresses bug STORM-797.
>     http://jira.secondlife.com/browse/STORM-797
> 
> 
> Diffs
> -----
> 
>   indra/llui/llurlentry.h 27dae7b01a81 
>   indra/llui/llurlentry.cpp 27dae7b01a81 
>   indra/llui/tests/llurlentry_stub.cpp 27dae7b01a81 
>   indra/newview/llagent.cpp 27dae7b01a81 
>   indra/newview/llappviewer.cpp 27dae7b01a81 
>   indra/newview/llremoteparcelrequest.cpp 27dae7b01a81 
>   indra/newview/llstartup.cpp 27dae7b01a81 
>   indra/newview/tests/llremoteparcelrequest_test.cpp 27dae7b01a81 
> 
> Diff: http://codereview.secondlife.com/r/69/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Seth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101230/77073bdf/attachment.htm