[opensource-dev] Review Request: (STORM-941) IM log naming should go by SL name, not DN.

Vadim ProductEngine vsavchuk at productengine.com
Mon Apr 11 08:39:11 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/249/#review582
-----------------------------------------------------------



indra/newview/llimview.cpp
<http://codereview.secondlife.com/r/249/#comment515>

    This looks even worse than the original fix: AFAIU, until the name is resolved, IMs won't be saved at all.


- Vadim


On April 7, 2011, 4:16 p.m., Seth ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/249/
> -----------------------------------------------------------
> 
> (Updated April 7, 2011, 4:16 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Fixed IM history to use the resident's user name for the log file name.
> Added conversions from legacy names or SLURLs with avatar id to the user names in cases of logging P2P sessions and inventory offers.
> 
> 
> This addresses bug STORM-941.
>     http://jira.secondlife.com/browse/STORM-941
> 
> 
> Diffs
> -----
> 
>   indra/newview/llgiveinventory.cpp d30636c2a83a 
>   indra/newview/llimview.h d30636c2a83a 
>   indra/newview/llimview.cpp d30636c2a83a 
>   indra/newview/llnotificationhandler.h d30636c2a83a 
>   indra/newview/llnotificationhandlerutil.cpp d30636c2a83a 
> 
> Diff: http://codereview.secondlife.com/r/249/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Seth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110411/a6a8e654/attachment.htm 


More information about the opensource-dev mailing list