[opensource-dev] Review Request: (STORM-941) IM log naming should go by SL name, not DN.

[Seth ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/249/
-----------------------------------------------------------

(Updated April 13, 2011, 8:11 a.m.)


Review request for Viewer.


Changes
-------

Removed asynchronous writes to temporary IM log file depending on name cache responses. Looks like there is no need for requesting names from cache or the name is already in cache in some cases, so no need for a callback.


Summary (updated)
-------

Fixed IM history to use the resident's user name for the log file name.
Added conversions from legacy names or SLURLs with avatar id to the user names in cases of logging P2P sessions and inventory offers.
Removed asynchronous writes to temporary IM log file depending on name cache responses.


This addresses bug STORM-941.
    http://jira.secondlife.com/browse/STORM-941


Diffs (updated)
-----

  indra/newview/llgiveinventory.cpp 4b5d458c03e8 
  indra/newview/llimview.h 4b5d458c03e8 
  indra/newview/llimview.cpp 4b5d458c03e8 
  indra/newview/llnotificationhandlerutil.cpp 4b5d458c03e8 
  indra/newview/llviewermessage.cpp 4b5d458c03e8 

Diff: http://codereview.secondlife.com/r/249/diff


Testing
-------


Thanks,

Seth

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110413/d86eafa0/attachment.htm