[opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/#review595
-----------------------------------------------------------



indra/newview/llfloaterworldmap.cpp
<http://codereview.secondlife.com/r/262/#comment547>

    Why do you make this a functor rather than a plain normal function? It's not like we have to keep any internal state or something.



indra/newview/llfloaterworldmap.cpp
<http://codereview.secondlife.com/r/262/#comment545>

    Wow, long line. Might want to put the arguments on separate lines.


- Boroondas


On April 13, 2011, 12:16 p.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/262/
> -----------------------------------------------------------
> 
> (Updated April 13, 2011, 12:16 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> The results of using the World Map search option are sorted.
> 
> 
> This addresses bug Storm-1128.
>     http://jira.secondlife.com/browse/Storm-1128
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt a8f868007986 
>   indra/newview/llfloaterworldmap.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/262/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110413/6f5a2508/attachment-0001.htm