[opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

Jonathan Yap jhwelch at gmail.com
Fri Apr 15 11:36:17 PDT 2011



> On April 13, 2011, 2:31 p.m., Boroondas Gupte wrote:
> > indra/newview/llfloaterworldmap.cpp, lines 99-101
> > <http://codereview.secondlife.com/r/262/diff/1/?file=1462#file1462line99>
> >
> >     Why do you make this a functor rather than a plain normal function? It's not like we have to keep any internal state or something.

Moved to inside of routine.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/#review595
-----------------------------------------------------------


On April 15, 2011, 11:33 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/262/
> -----------------------------------------------------------
> 
> (Updated April 15, 2011, 11:33 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> The results of using the World Map search option are sorted.
> 
> 
> This addresses bug Storm-1128.
>     http://jira.secondlife.com/browse/Storm-1128
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt a8f868007986 
>   indra/newview/llfloaterworldmap.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/262/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110415/bfbf446a/attachment.htm 


More information about the opensource-dev mailing list