[opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map
Boroondas Gupte
sllists at boroon.dasgupta.ch
Fri Apr 15 13:31:00 PDT 2011
> On April 13, 2011, 2:31 p.m., Boroondas Gupte wrote:
> > indra/newview/llfloaterworldmap.cpp, lines 99-101
> > <http://codereview.secondlife.com/r/262/diff/1/?file=1462#file1462line99>
> >
> > Why do you make this a functor rather than a plain normal function? It's not like we have to keep any internal state or something.
>
> Jonathan Yap wrote:
> Moved to inside of routine.
That's a good idea, too, but not what I meant. I was wondering why you are using a class (or struct) with an operator() instead of just a function. std::sort can take either a functor (i.e. a callable object like you're using here) or a function pointer.
- Boroondas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/#review595
-----------------------------------------------------------
On April 15, 2011, 11:33 a.m., Jonathan Yap wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/262/
> -----------------------------------------------------------
>
> (Updated April 15, 2011, 11:33 a.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> The results of using the World Map search option are sorted.
>
>
> This addresses bug Storm-1128.
> http://jira.secondlife.com/browse/Storm-1128
>
>
> Diffs
> -----
>
> doc/contributions.txt a8f868007986
> indra/newview/llfloaterworldmap.cpp a8f868007986
>
> Diff: http://codereview.secondlife.com/r/262/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110415/eac1c3ab/attachment.htm
More information about the opensource-dev
mailing list