[opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

[Jonathan Yap]

> On July 20, 2011, 11:14 a.m., Boroondas Gupte wrote:
> > indra/newview/lltoolplacer.cpp, lines 391-393
> > <http://codereview.secondlife.com/r/317/diff/1/?file=2852#file2852line391>
> >
> >     Remove the empty line.

Done


> On July 20, 2011, 11:14 a.m., Boroondas Gupte wrote:
> > indra/newview/lltoolplacer.cpp, lines 394-404
> > <http://codereview.secondlife.com/r/317/diff/1/?file=2852#file2852line394>
> >
> >     Where are these numbers coming from? Are they used elsewhere in the code?

These numbers are copied from another place in the code dealing with converting an object to the sculpt type.  In file \newview\llpanelobject.cpp see the end of getVolumeParams.


> On July 20, 2011, 11:14 a.m., Boroondas Gupte wrote:
> > indra/newview/llviewerobjectlist.h, lines 252-255
> > <http://codereview.secondlife.com/r/317/diff/1/?file=2853#file2853line252>
> >
> >     Please re-introduce the empty line before
> >     // Inlines

Done.


> On July 20, 2011, 11:14 a.m., Boroondas Gupte wrote:
> > indra/newview/llviewerobjectlist.cpp, line 96
> > <http://codereview.secondlife.com/r/317/diff/1/?file=2854#file2854line96>
> >
> >     Is a global variable really the way to go here? Also, please add a short comment explaining the semantics of this variable.

Comment added.  Robin Cornelius suggested using a global variable.  If you can think of a better way please let me know.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/317/#review895
-----------------------------------------------------------


On June 2, 2011, 2:03 p.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/317/
> -----------------------------------------------------------
> 
> (Updated June 2, 2011, 2:03 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.
> 
> I have added a new Sculpt icon to the list of available object types that can be selected on the build menu.  You can now rez a sculpt the same way you do a cube.
> 
> Possible issue: I made up a new Pcode used only by the viewer.
> 
> 
> This addresses bug STORM-49.
>     http://jira.secondlife.com/browse/STORM-49
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt a36a329e77cc 
>   indra/llmath/llvolume.h a36a329e77cc 
>   indra/llprimitive/llprimitive.cpp a36a329e77cc 
>   indra/newview/llfloatertools.cpp a36a329e77cc 
>   indra/newview/lltoolplacer.cpp a36a329e77cc 
>   indra/newview/llviewerobjectlist.h a36a329e77cc 
>   indra/newview/llviewerobjectlist.cpp a36a329e77cc 
>   indra/newview/skins/default/textures/build/Object_Sculpt.png a36a329e77cc 
>   indra/newview/skins/default/textures/build/Object_Sculpt_Selected.png a36a329e77cc 
>   indra/newview/skins/default/textures/textures.xml a36a329e77cc 
>   indra/newview/skins/default/xui/en/floater_tools.xml a36a329e77cc 
> 
> Diff: http://codereview.secondlife.com/r/317/diff
> 
> 
> Testing
> -------
> 
> Rezzed a sculpt both alone and with someone watching.
> 
> Rezzed sculpts as fast as I could click (poor mans load test).
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110803/89ba6c5d/attachment.htm