[opensource-dev] Review Request: STORM-1309 [TEXT ELLIPTED] Text overlaying in Buy Land floater in Portuguese localization

Seth ProductEngine slitovchuk at productengine.com
Fri Aug 5 11:06:19 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/430/#review952
-----------------------------------------------------------

Ship it!


Looks good to me.

- Seth


On Aug. 5, 2011, 7:53 a.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/430/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2011, 7:53 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Misc i18n fixes in the Buy Land floater:
> * Appended a space after the colon in "Last modified:".
>   It seems to have been mistakenly omitted by translators.
> * Fixed timestamp (last modified date) value truncation.
> * Proper truncation of region name, region type, estate name and estate owner text.
>   o Use ellipses for truncation.
>   o Where applicable, set tooltip to contain the uncut text.
>   o Leave a few pixels of padding between the text and the floater right border.
> * Fixed maturity rating icon overlapping the floater right border.
>   The code that places it now takes into account possible region name text truncation.
> 
> 
> This addresses bug STORM-1309.
>     http://jira.secondlife.com/browse/STORM-1309
> 
> 
> Diffs
> -----
> 
>   indra/newview/llfloaterbuyland.cpp 0fd2a1181a96 
>   indra/newview/skins/default/xui/da/strings.xml 0fd2a1181a96 
>   indra/newview/skins/default/xui/de/strings.xml 0fd2a1181a96 
>   indra/newview/skins/default/xui/en/floater_buy_land.xml 0fd2a1181a96 
>   indra/newview/skins/default/xui/it/strings.xml 0fd2a1181a96 
>   indra/newview/skins/default/xui/nl/strings.xml 0fd2a1181a96 
>   indra/newview/skins/default/xui/pl/strings.xml 0fd2a1181a96 
>   indra/newview/skins/default/xui/pt/strings.xml 0fd2a1181a96 
>   indra/newview/skins/default/xui/zh/strings.xml 0fd2a1181a96 
> 
> Diff: http://codereview.secondlife.com/r/430/diff
> 
> 
> Testing
> -------
> 
> Tested locales: EN, DE, PT.
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110805/2c472a5c/attachment.htm 


More information about the opensource-dev mailing list