[opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

[Nicky Perian]

the file ogg-vorbis-1.1.3-1.2.0-windows-20101001a.tar.bz2 is in autobuild.xml 
and is in the install.cache.xxxx and does download manually
 



________________________________
From: Nicky Perian <nickyperian at yahoo.com>
To: Nicky Perian <nickyperian at yahoo.com>; Oz Linden <oz at lindenlab.com>; Viewer 
<opensource-dev at lists.secondlife.com>
Sent: Fri, January 28, 2011 12:34:52 PM
Subject: Re: Review Request: Do not fail when no scp command is found, unless it 
is actually needed to fetch something


This is an automatically generated e-mail. To reply, visit: 
http://codereview.secondlife.com/r/127/  


Ship it!
Worked as designed/explained. For other dummies like me if you did setup.py 
install before the patch,  you need to repeat it to get the new patched version 
working in python.

- Nicky

On January 28th, 2011, 5:20 a.m., Oz Linden wrote:
Review request for Viewer.
By Oz Linden.
Updated Jan. 28, 2011, 5:20 a.m.
Description 
During initialization, if there is no scp or pscp command found then autobuild 
fails immediately.  This is true whether or not any scp urls need to be used.  
This change modifies the behavior so that a warning is printed if no command is 
found, but execution proceeds until an scp command is needed, at which time 
execution fails with an explanatory message.  This patch can print the warning 
multiple times - I didn't attempt to suppress the extras. 

Testing 
I've tested this locally, simulating the error by temporarily modifying the 
names of the commands to be found for scp.  I have not checked it on Windows, 
where the original problem was found. 

Diffs 
	* autobuild/common.py (f49808fe3c07)
View Diff 


      
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110201/e672fc4a/attachment-0001.htm