[opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2

Boroondas Gupte sllists at boroon.dasgupta.ch
Mon Feb 7 12:39:22 PST 2011



> On Jan. 20, 2011, 11:33 p.m., Merov Linden wrote:
> > I'm advising the MM to merge in a test repo and do a full TC cycle on all platforms before merging though...
> 
> Boroondas Gupte wrote:
>     As far as I can see indra/cmake/FindLLQtWebkit.cmake only gets called by indra/cmake/WebKitLibPlugin.cmake (through find_package(LLQtWebkit REQUIRED QUIET)), and there the call only happens for STANDALONE. So I would be very surprised if this affects TC builds.

Any results from that TC cycle?


- Boroondas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/97/#review227
-----------------------------------------------------------


On Jan. 17, 2011, 10:03 a.m., Boroondas Gupte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/97/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2011, 10:03 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Only use QUIET in pkg_check_modules() on CMake >=2.8.2 (where it's supported) rather than already on CMake >=2.8.
> 
> 
> This addresses bug VWR-24520.
>     http://jira.secondlife.com/browse/VWR-24520
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 9e99b2c8fb28 
>   indra/cmake/FindLLQtWebkit.cmake 9e99b2c8fb28 
> 
> Diff: http://codereview.secondlife.com/r/97/diff
> 
> 
> Testing
> -------
> 
> Configured (standalone) without a .pgk file for libllqtwebkit on Linux with CMake 2.8.1 and CMake 2.8.3. Output as expected.
> 
> Not tested:
> * CMake 2.8.2
> * system with a .pgk file for libllqtwebkit
> * non-standalone
> * Mac, Win
> 
> 
> Thanks,
> 
> Boroondas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110207/7c147886/attachment.htm 


More information about the opensource-dev mailing list