[opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

Boroondas Gupte sllists at boroon.dasgupta.ch
Fri Feb 18 07:22:10 PST 2011



> On Feb. 18, 2011, 7:16 a.m., Jonathan Yap wrote:
> > My internet connection went dead while in the middle of updating the diffs.  They are corrupted and I don't know how to fix them.

Have you tried uploading them again? That won't remove the bogus intermediary revision, but if we know about that, we can easily ignore it.

Btw., after uploading, you can review the new diff before publishing it, I think: While on the page where you can describe the update, click the "View Diff" button.


- Boroondas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/139/#review376
-----------------------------------------------------------


On Feb. 18, 2011, 7:11 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/139/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2011, 7:11 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This is a request for help.  I am trying to learn more about c++ and how variables in one class are accessed from another.  For someone who knows what they are doing this is probably a pretty easy question.
> 
> I have been able to set the font size on the chat input box when it is created in llbottomtray.cpp.  I would like to do the same thing when someone clicks in that box to input text; it is possible they have changed the font setting and I would like to apply the size there as well, but I am stuck on how to do this.  I think the right place to do this is in llchatbar.cpp/LLChatBar::onInputEditorGainFocus().
> 
> I have tried all kinds of wrong ways but at this point am stymied.
> 
> Exact steps on how to proceed would be appreciated.
> 
> 
> This addresses bug vwr-22220.
>     http://jira.secondlife.com/browse/vwr-22220
> 
> 
> Diffs
> -----
> 
>   indra/newview/llbottomtray.h 3d2e71443c58 
>   indra/newview/llbottomtray.cpp 3d2e71443c58 
>   indra/newview/llchatbar.h 3d2e71443c58 
>   indra/newview/llchatbar.cpp 3d2e71443c58 
> 
> Diff: http://codereview.secondlife.com/r/139/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110218/bc6b2cee/attachment.htm 


More information about the opensource-dev mailing list