[opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations
Oz Linden
oz at lindenlab.com
Wed Jan 5 08:33:27 PST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/32/
-----------------------------------------------------------
(Updated Jan. 5, 2011, 8:33 a.m.)
Review request for Viewer.
Changes
-------
modified to correct the issue pointer
Summary
-------
Fixed LLDir unit test which failed for some complex wildcard combinations.
Added a class implementing directory entries iteration with pattern matching which is used in unit tests instead of LLDir::getNextFileInDir.
This code has been run on Linux only. It should be tested under other platforms and more test cases should be provided. For example changing directory contents while iterating through it.
This addresses bug STORM-477.
http://jira.secondlife.com/browse/STORM-477
Diffs
-----
indra/cmake/Boost.cmake 27dae7b01a81
indra/llvfs/CMakeLists.txt 27dae7b01a81
indra/llvfs/lldiriterator.h PRE-CREATION
indra/llvfs/lldiriterator.cpp PRE-CREATION
indra/llvfs/tests/lldir_test.cpp 27dae7b01a81
Diff: http://codereview.secondlife.com/r/32/diff
Testing
-------
Thanks,
Seth
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110105/f3cb8cbe/attachment.htm
More information about the opensource-dev
mailing list