[opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations

[Oz Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/32/#review112
-----------------------------------------------------------


Just one policy question with this...

This implementation uses llwarns for various errors in the glob expression.

Given that I expect that the glob expression will normally (always?) be hard coded (I hope no one will accept a pattern as input from the user and pass it on unverified), should these use llerrs so that the error cannot be missed (it crashes)?

Other than that, this looks good now.

- Oz


On Jan. 5, 2011, 8:33 a.m., Seth ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/32/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2011, 8:33 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Fixed LLDir unit test which failed for some complex wildcard combinations.
> Added a class implementing directory entries iteration with pattern matching which is used in unit tests instead of LLDir::getNextFileInDir.
> 
> This code has been run on Linux only. It should be tested under other platforms and more test cases should be provided. For example changing directory contents while iterating through it.
> 
> 
> This addresses bug STORM-477.
>     http://jira.secondlife.com/browse/STORM-477
> 
> 
> Diffs
> -----
> 
>   indra/cmake/Boost.cmake 27dae7b01a81 
>   indra/llvfs/CMakeLists.txt 27dae7b01a81 
>   indra/llvfs/lldiriterator.h PRE-CREATION 
>   indra/llvfs/lldiriterator.cpp PRE-CREATION 
>   indra/llvfs/tests/lldir_test.cpp 27dae7b01a81 
> 
> Diff: http://codereview.secondlife.com/r/32/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Seth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110105/573c13cc/attachment.htm