[opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages
Jonathan Yap
jhwelch at gmail.com
Thu Jan 6 04:17:13 PST 2011
> On Jan. 5, 2011, 7:33 p.m., Wolfpup Lowenhar wrote:
> > indra/newview/llviewermessage.cpp, line 2752
> > <http://codereview.secondlife.com/r/71/diff/1/?file=327#file327line2752>
> >
> > Looks good to me, but just wondering why your checking for "/me " and "/me'" .
That is the check used in other parts of the code and as was pointed out in the mailing list you can type /me's happy
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/71/#review114
-----------------------------------------------------------
On Jan. 5, 2011, 6:14 p.m., Jonathan Yap wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/71/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2011, 6:14 p.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> The "/me" in the lsl code below would be displayed rather than being translated to a name:
> llInstantMessage(llGetOwner(),"/me Hello, Avatar!");
>
>
> This addresses bug STORM-829.
> http://jira.secondlife.com/browse/STORM-829
>
>
> Diffs
> -----
>
> indra/newview/llviewermessage.cpp 845cab866155
>
> Diff: http://codereview.secondlife.com/r/71/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110106/40f3ced1/attachment.htm
More information about the opensource-dev
mailing list