[opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/70/#review131
-----------------------------------------------------------


Still CRLFs in indra/newview/skins/default/xui/en/floater_web_content.xml , which isn't windows specific, I think.
Otherwise https://bitbucket.org/oz_linden/storm-826/changeset/6e6d1de23cce looks good.

I'm wondering whether we should also fix indentation on lines that are touched by this change anyway. (E.g. floater_web_content.xml mixes spaces and tabs.)

- Boroondas


On Jan. 6, 2011, 10:20 a.m., Oz Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/70/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2011, 10:20 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This is a simple change to correct existing line endings - I scanned all of viewer-development to identify files that had a mixture of CRLF and LF endings and converted them to just LF.
> 
> The diff apparently won't show the change in line ending characters.... see the repo (in the issue) for the real change.
> I expanded the scope of this to also convert some files that were all the same CRLF endings but did not obviously need to be.   I left files that were clearly windows specific alone on the theory that non-windows users probably won't need to touch them, and the windows tools might care.
> 
> 
> This addresses bug storm-826.
>     http://jira.secondlife.com/browse/storm-826
> 
> 
> Diffs
> -----
> 
>   indra/cmake/GetPrerequisites_2_8.cmake 6d44f0d85a80 
>   indra/cmake/LLAddBuildTest.cmake 6d44f0d85a80 
>   indra/newview/llfloaterwebcontent.h 6d44f0d85a80 
>   indra/newview/llfloaterwebcontent.cpp 6d44f0d85a80 
>   indra/newview/llimview.h 6d44f0d85a80 
>   indra/newview/llimview.cpp 6d44f0d85a80 
>   indra/newview/lllogchat.cpp 6d44f0d85a80 
>   indra/newview/tests/llremoteparcelrequest_test.cpp 6d44f0d85a80 
>   indra/viewer_components/updater/tests/llupdaterservice_test.cpp 6d44f0d85a80 
> 
> Diff: http://codereview.secondlife.com/r/70/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110107/dffef04a/attachment.htm