[opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder
Vadim ProductEngine
vsavchuk at productengine.com
Sun Jan 16 07:37:41 PST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/77/#review170
-----------------------------------------------------------
indra/newview/llpanellandmarks.cpp
<http://codereview.secondlife.com/r/77/#comment110>
Why are the checks for are_all_items_in_trash and are_any_items_in_trash different?
I guess it should be something like:
bool item_in_trash = listenerp->isItemInTrash() && *iter != trash_id;
are_all_items_in_trash &= item_in_trash;
are_any_items_in_trash |= item_in_trash;
indra/newview/llpanellandmarks.cpp
<http://codereview.secondlife.com/r/77/#comment111>
Although we use the same approach in the Appearance SP for enabling/displaying context menu items, it may be not what users expect. Please clearly state this behavior in the ticket comment for PO to notice.
- Vadim
On Jan. 14, 2011, 4:13 p.m., Seth ProductEngine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/77/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2011, 4:13 p.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> Added "Restore Item" context menu entry for landmarks and folders in Trash category in Places->My Landmarks->My Inventory accordion tab.
>
>
> This addresses bug STORM-383.
> http://jira.secondlife.com/browse/STORM-383
>
>
> Diffs
> -----
>
> indra/newview/llpanellandmarks.h 422f636c3343
> indra/newview/llpanellandmarks.cpp 422f636c3343
> indra/newview/skins/default/xui/en/menu_places_gear_folder.xml 422f636c3343
> indra/newview/skins/default/xui/en/menu_places_gear_landmark.xml 422f636c3343
>
> Diff: http://codereview.secondlife.com/r/77/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Seth
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110116/245aed93/attachment.htm
More information about the opensource-dev
mailing list