[opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder

[Seth ProductEngine]

> On Jan. 16, 2011, 7:37 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanellandmarks.cpp, lines 1127-1132
> > <http://codereview.secondlife.com/r/77/diff/1/?file=436#file436line1127>
> >
> >     Why are the checks for are_all_items_in_trash and are_any_items_in_trash different?
> >     
> >     I guess it should be something like:
> >     
> >       bool item_in_trash = listenerp->isItemInTrash() && *iter != trash_id;
> >       are_all_items_in_trash &= item_in_trash;
> >       are_any_items_in_trash |= item_in_trash;

Probably it will look more pretty this way. But the checks should remain different in order not to enable "Restore Item" when Trash folder is selected and not to display an empty menu when some of the selected items are in Trash and some aren't.


- Seth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/77/#review170
-----------------------------------------------------------


On Jan. 17, 2011, 8:17 a.m., Seth ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/77/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2011, 8:17 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Added "Restore Item" context menu entry for landmarks and folders in Trash category in Places->My Landmarks->My Inventory accordion tab.
> 
> 
> This addresses bug STORM-383.
>     http://jira.secondlife.com/browse/STORM-383
> 
> 
> Diffs
> -----
> 
>   indra/newview/llpanellandmarks.h 422f636c3343 
>   indra/newview/llpanellandmarks.cpp 422f636c3343 
>   indra/newview/skins/default/xui/en/menu_places_gear_folder.xml 422f636c3343 
>   indra/newview/skins/default/xui/en/menu_places_gear_landmark.xml 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/77/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Seth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110117/4d5ec0c1/attachment-0001.htm