[opensource-dev] Review Request: VWR-24100 Settings.xml: redundant entries and unnecessary tag
Kent Quirk
q at lindenlab.com
Tue Jan 18 08:42:25 PST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/18/#review182
-----------------------------------------------------------
Ship it!
These changes are all reasonable. Please go ahead.
- Kent
On Dec. 23, 2010, 12:12 p.m., Jonathan Yap wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/18/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2010, 12:12 p.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> I wrote two programs that use settings.xml to produce this massive table:
> http://wiki.secondlife.com/wiki/Debug_Settings
>
> While doing this I found 4 places with duplicate entries and 1 entry that is repeated 4 times. There is also a pair of unnecessary tags.
>
> Having these cleaned out would make running my program, and thus updating the wiki table, easier.
>
> I've erased all but the last entry for these redundant debug settings.
>
>
> This addresses bug vwr-24100.
> http://jira.secondlife.com/browse/vwr-24100
>
>
> Diffs
> -----
>
> indra/newview/app_settings/settings.xml 46a990f8296f
>
> Diff: http://codereview.secondlife.com/r/18/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110118/b9383b80/attachment.htm
More information about the opensource-dev
mailing list