[opensource-dev] Review Request: STORM-373 "Rename" context menu option disabled for incomplete inventory items
Seth ProductEngine
slitovchuk at productengine.com
Tue Jan 18 11:26:00 PST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/101/#review187
-----------------------------------------------------------
Ship it!
Looks good to me. Seems like adding another observer is necessary to deal with this issue.
- Seth
On Jan. 18, 2011, 8:20 a.m., Vadim ProductEngine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/101/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2011, 8:20 a.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> Refresh the inventory context menu (which enables the "Rename" option) after the selected item(s) gets fetched.
>
> I'm a bit worried by adding another inventory observer to each inventory panel, but I couldn't come up with a solution which is more elegant and affects performance less.
>
>
> This addresses bug STORM-373.
> http://jira.secondlife.com/browse/STORM-373
>
>
> Diffs
> -----
>
> indra/newview/llfolderview.h 422f636c3343
> indra/newview/llfolderview.cpp 422f636c3343
> indra/newview/llinventorypanel.h 422f636c3343
> indra/newview/llinventorypanel.cpp 422f636c3343
>
> Diff: http://codereview.secondlife.com/r/101/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vadim
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110118/76f27bc7/attachment.htm
More information about the opensource-dev
mailing list