[opensource-dev] Review Request: STORM-610 Changes to Environment Editor: water color change is not saved

Vadim ProductEngine vsavchuk at productengine.com
Thu Jan 27 13:20:54 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/125/
-----------------------------------------------------------

Review request for Viewer and Seth ProductEngine.


Summary
-------

Now when you change water color or density, the changes are saved until you switch to another water preset.


This addresses bug STORM-610.
    http://jira.secondlife.com/browse/STORM-610


Diffs
-----

  indra/newview/app_settings/settings.xml b542f8134a2b 
  indra/newview/llwaterparammanager.h b542f8134a2b 
  indra/newview/llwaterparammanager.cpp b542f8134a2b 

Diff: http://codereview.secondlife.com/r/125/diff


Testing
-------

Played with presets and sliders. The new behavior seems fine to me, although it may be confusing that basic water settings are persistent, while sky settings aren't.

While working on this bug I've almost (~80%) implemented STORM-326 (Persistent water/sky settings), so if anyone is interested I'd be happy to complete that work.


Thanks,

Vadim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110127/23e22be8/attachment.htm 


More information about the opensource-dev mailing list