[opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

Alain Linden alain at lindenlab.com
Fri Jan 28 14:46:24 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/127/#review274
-----------------------------------------------------------



autobuild/common.py
<http://codereview.secondlife.com/r/127/#comment214>

    Why not use None here? I think that is more Pythonie.



autobuild/common.py
<http://codereview.secondlife.com/r/127/#comment215>

    ...and test for None here.


- Alain


On Jan. 28, 2011, 5:20 a.m., Oz Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/127/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2011, 5:20 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> During initialization, if there is no scp or pscp command found then autobuild fails immediately.  This is true whether or not any scp urls need to be used.
> 
> This change modifies the behavior so that a warning is printed if no command is found, but execution proceeds until an scp command is needed, at which time execution fails with an explanatory message.
> 
> This patch can print the warning multiple times - I didn't attempt to suppress the extras.
> 
> 
> Diffs
> -----
> 
>   autobuild/common.py f49808fe3c07 
> 
> Diff: http://codereview.secondlife.com/r/127/diff
> 
> 
> Testing
> -------
> 
> I've tested this locally, simulating the error by temporarily modifying the names of the commands to be found for scp.
> 
> I have not checked it on Windows, where the original problem was found.
> 
> 
> Thanks,
> 
> Oz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110128/d59eef4a/attachment.htm 


More information about the opensource-dev mailing list