[opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something
Boroondas Gupte
sllists at boroon.dasgupta.ch
Sat Jan 29 03:40:28 PST 2011
> On Jan. 28, 2011, 2:46 p.m., Alain Linden wrote:
> > autobuild/common.py, line 415
> > <http://codereview.secondlife.com/r/127/diff/1/?file=654#file654line415>
> >
> > ...and test for None here.
Good idea. This would avoid bugs that could occur e.g. when the string is changed and not spelled the same in both places.
- Boroondas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/127/#review274
-----------------------------------------------------------
On Jan. 28, 2011, 5:20 a.m., Oz Linden wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/127/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2011, 5:20 a.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> During initialization, if there is no scp or pscp command found then autobuild fails immediately. This is true whether or not any scp urls need to be used.
>
> This change modifies the behavior so that a warning is printed if no command is found, but execution proceeds until an scp command is needed, at which time execution fails with an explanatory message.
>
> This patch can print the warning multiple times - I didn't attempt to suppress the extras.
>
>
> Diffs
> -----
>
> autobuild/common.py f49808fe3c07
>
> Diff: http://codereview.secondlife.com/r/127/diff
>
>
> Testing
> -------
>
> I've tested this locally, simulating the error by temporarily modifying the names of the commands to be found for scp.
>
> I have not checked it on Windows, where the original problem was found.
>
>
> Thanks,
>
> Oz
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110129/89ce5ad9/attachment-0001.htm
More information about the opensource-dev
mailing list