[opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

[Oz Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/127/
-----------------------------------------------------------

(Updated Jan. 29, 2011, 5:01 a.m.)


Review request for Viewer.


Changes
-------

removed the (possibly repeated) warnings about not finding an scp command
changed to using None properly rather than a fixed string value

(added logging that should have shown for doing scp copies, but --verbose does not seem to do anything.... different issue)


Summary
-------

During initialization, if there is no scp or pscp command found then autobuild fails immediately.  This is true whether or not any scp urls need to be used.

This change modifies the behavior so that a warning is printed if no command is found, but execution proceeds until an scp command is needed, at which time execution fails with an explanatory message.

This patch can print the warning multiple times - I didn't attempt to suppress the extras.


Diffs (updated)
-----

  autobuild/common.py 9ae505976dfa 

Diff: http://codereview.secondlife.com/r/127/diff


Testing
-------

I've tested this locally, simulating the error by temporarily modifying the names of the commands to be found for scp.

I have not checked it on Windows, where the original problem was found.


Thanks,

Oz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110129/c39ec48c/attachment.htm