[opensource-dev] Review Request: VWR-24667; Copy3rdPartyLibs.cmake needs to account for Visual Studio 10 and Visual Studio 10 Express.

Jonathan Yap jhwelch at gmail.com
Sun Jan 30 22:46:03 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/131/#review282
-----------------------------------------------------------



indra/cmake/Copy3rdPartyLibs.cmake
<http://codereview.secondlife.com/r/131/#comment221>

    Examine the attached file in https://jira.secondlife.com/browse/STORM-932 and my comment at the bottom on how to avoid duplicating code in this file.


- Jonathan


On Jan. 30, 2011, 8:55 p.m., Nicky Perian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/131/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2011, 8:55 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Copy3rdPartyLibs.cmake need to respond correctly under Visual Studio 10 and Visual Studio 10 Express Edition.
> 
>  
> 
> 
> This addresses bug VWR-24667.
>     http://jira.secondlife.com/browse/VWR-24667
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 691e3941d950 
>   indra/cmake/Copy3rdPartyLibs.cmake 691e3941d950 
> 
> Diff: http://codereview.secondlife.com/r/131/diff
> 
> 
> Testing
> -------
> 
> Tested good under windows 7 64 bit and Visual Studio 10 Express Edition.
> 
> 
> Thanks,
> 
> Nicky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110131/1b3f5c72/attachment-0001.htm 


More information about the opensource-dev mailing list