[opensource-dev] Review Request: VWR-24667; Copy3rdPartyLibs.cmake needs to account for Visual Studio 10 and Visual Studio 10 Express.
Nicky Perian
nickyperian at yahoo.com
Mon Jan 31 07:34:38 PST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/131/
-----------------------------------------------------------
(Updated Jan. 31, 2011, 7:34 a.m.)
Review request for Viewer.
Changes
-------
Modified to include Jonathan Yap's review recommendation from https://jira.secondlife.com/browse/STORM-932. Added code from merov's wip at https://jira.secondlife.com/browse/STORM-860 variable declarations for MSVC_DIR and MSVC_SUFFIX and added values for Visual Studio 10.
Tested OK under windows 7 64 bit and Visual Studio 10 Express Edition.
Summary
-------
Copy3rdPartyLibs.cmake need to respond correctly under Visual Studio 10 and Visual Studio 10 Express Edition.
This addresses bug VWR-24667.
http://jira.secondlife.com/browse/VWR-24667
Diffs (updated)
-----
indra/cmake/Copy3rdPartyLibs.cmake 691e3941d950
Diff: http://codereview.secondlife.com/r/131/diff
Testing
-------
Tested good under windows 7 64 bit and Visual Studio 10 Express Edition.
Thanks,
Nicky
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110131/7efe04c2/attachment.htm
More information about the opensource-dev
mailing list