[opensource-dev] Review Request: STORM-1460 (Cursor doesn't go to the input field on the Find Floater due to lack of window focus)

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/386/#review853
-----------------------------------------------------------


I think this is a hack. The embedded browser should not differ from other widgets in terms of focus hangling.
Imagine you have a button. Once the floater is created, you focus the button. That's it. You're not waiting for some event within the button.
So why don't you just focus the web browser control in postBuild()? Why does the floater have to know so much about page loading stuff?

- Vadim


On July 8, 2011, 5:16 a.m., Paul ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/386/
> -----------------------------------------------------------
> 
> (Updated July 8, 2011, 5:16 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Reason:
> Focus didn't go to the browser
> 
> Solution:
> Set the focus to the browser if a page is loaded and a floater containing a browser has a focus
> 
> 
> This addresses bug storm-1460.
>     http://jira.secondlife.com/browse/storm-1460
> 
> 
> Diffs
> -----
> 
>   indra/newview/llfloatersearch.h 68ad362920c1 
>   indra/newview/llfloatersearch.cpp 68ad362920c1 
> 
> Diff: http://codereview.secondlife.com/r/386/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110708/bc98bf21/attachment.htm