[opensource-dev] Review Request: STORM-1460 (Cursor doesn't go to the input field on the Find Floater due to lack of window focus)

[Richard Nelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/386/#review854
-----------------------------------------------------------


Please don't use code to manually set focus unless you know for sure that xui-based focus control doesn't work.

In this case, just add tab_stop="true" to the web_browser widget inside floater_search.xml

- Richard


On July 8, 2011, 5:16 a.m., Paul ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/386/
> -----------------------------------------------------------
> 
> (Updated July 8, 2011, 5:16 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Reason:
> Focus didn't go to the browser
> 
> Solution:
> Set the focus to the browser if a page is loaded and a floater containing a browser has a focus
> 
> 
> This addresses bug storm-1460.
>     http://jira.secondlife.com/browse/storm-1460
> 
> 
> Diffs
> -----
> 
>   indra/newview/llfloatersearch.h 68ad362920c1 
>   indra/newview/llfloatersearch.cpp 68ad362920c1 
> 
> Diff: http://codereview.secondlife.com/r/386/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110708/6c6b1a65/attachment-0001.htm