[opensource-dev] Review Request: STORM-787 Mute Gestures Button

[Oz Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/336/#review749
-----------------------------------------------------------

Ship it!


- Oz


On June 12, 2011, 1:09 p.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/336/
> -----------------------------------------------------------
> 
> (Updated June 12, 2011, 1:09 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Added a checkbox control in Preferences->Sound and Media (see attached image in jira) to enable/disable sounds coming from gestures.
> 
> There is a long writeup in the jira for reasons to have this.
> 
> This control is linked to 1) the master volume control and 2) the sound effects control.  If either of these is disabled (speaker has a red line through it) the checkbox is disabled.
> 
> 
> This addresses bug STORM-787.
>     http://jira.secondlife.com/browse/STORM-787
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 6a3e7e403bd1 
>   indra/newview/app_settings/settings.xml 6a3e7e403bd1 
>   indra/newview/llfloaterpreference.h 6a3e7e403bd1 
>   indra/newview/llfloaterpreference.cpp 6a3e7e403bd1 
>   indra/newview/llviewermessage.cpp 6a3e7e403bd1 
>   indra/newview/skins/default/xui/en/panel_preferences_sound.xml 6a3e7e403bd1 
> 
> Diff: http://codereview.secondlife.com/r/336/diff
> 
> 
> Testing
> -------
> 
> Tested per test plan in jira.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110615/57e35fa0/attachment.htm