[opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Kadah Coba]

> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanelpermissions.cpp, line 1027
> > <http://codereview.secondlife.com/r/365/diff/2-3/?file=3041#file3041line1027>
> >
> >     CS: check_purchase or better check_purchase_cb

Same name is used else where in the legacy code, should I change both while I'm at it?


> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanelpermissions.cpp, line 1118
> > <http://codereview.secondlife.com/r/365/diff/2-3/?file=3041#file3041line1118>
> >
> >     dead code

Mistake while merging, will clean


> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanelpermissions.cpp, line 443
> > <http://codereview.secondlife.com/r/365/diff/2-3/?file=3041#file3041line443>
> >
> >     Please separate comments from "//" with a space, i.e. write "// Check if..."

I don't think that was in the CS wiki doc. Will fix comments


- Kadah


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review831
-----------------------------------------------------------


On June 29, 2011, 4:54 p.m., Kadah Coba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> -----------------------------------------------------------
> 
> (Updated June 29, 2011, 4:54 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This change makes it so setting an object for sale or modifying the price or sale type requires explicitly applying the changes. Default behavior before this patch is all sale info is committed to sim on change. After this patch the sale info will only get set or modified after hitting a "mark for sale" button. There is no change to removing an object from sale, unchecking "For sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/vwr-21522
> Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
> German translation: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588
> 
> 
> This addresses bug VWR-21522.
>     http://jira.secondlife.com/browse/VWR-21522
> 
> 
> Diffs
> -----
> 
>   indra/newview/skins/default/xui/de/floater_tools.xml b245a988d038 
>   indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 
>   indra/newview/llpanelpermissions.h b245a988d038 
>   indra/newview/llpanelpermissions.cpp b245a988d038 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> -------
> 
> (I had stuff here but Review Board kept deleting it every time I tried to save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110630/d546a3fd/attachment.htm