[opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Vadim ProductEngine]

> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanelpermissions.cpp, line 1027
> > <http://codereview.secondlife.com/r/365/diff/2-3/?file=3041#file3041line1027>
> >
> >     CS: check_purchase or better check_purchase_cb
> 
> Kadah Coba wrote:
>     Same name is used else where in the legacy code, should I change both while I'm at it?

Well, you generally don't have to fix CS in code that you didn't modify.
But in this case the change seems to be small and related to your work, so please do.


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review831
-----------------------------------------------------------


On June 30, 2011, 10:33 a.m., Kadah Coba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> -----------------------------------------------------------
> 
> (Updated June 30, 2011, 10:33 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This change makes it so setting an object for sale or modifying the price or sale type requires explicitly applying the changes. Default behavior before this patch is all sale info is committed to sim on change. After this patch the sale info will only get set or modified after hitting a "mark for sale" button. There is no change to removing an object from sale, unchecking "For sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/vwr-21522
> Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
> German translation: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588
> 
> 
> This addresses bug VWR-21522.
>     http://jira.secondlife.com/browse/VWR-21522
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt UNKNOWN 
>   indra/newview/llpanelpermissions.h UNKNOWN 
>   indra/newview/llpanelpermissions.cpp UNKNOWN 
>   indra/newview/skins/default/xui/de/floater_tools.xml UNKNOWN 
>   indra/newview/skins/default/xui/en/floater_tools.xml UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> -------
> 
> (I had stuff here but Review Board kept deleting it every time I tried to save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110630/948c0778/attachment.htm