[opensource-dev] Review Request: STORM-1044 Improved message template checking.

Kelly Washington kelly at lindenlab.com
Thu Mar 3 14:20:54 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/174/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

Improved message template checking.
* If no changes have been made to the message template the check is local only and trivial.
* If changes have been made to the message template then compatibility is verified on the first build after the change instead of when they package.
* Automated systems can use --force to force full message template verification


This addresses bug STORM-1044.
    http://jira.secondlife.com/browse/STORM-1044


Diffs
-----

  indra/cmake/TemplateCheck.cmake 3683d7c533f9 
  indra/newview/CMakeLists.txt 3683d7c533f9 
  scripts/messages/message_template.msg.sha1 PRE-CREATION 
  scripts/template_verifier.py 3683d7c533f9 

Diff: http://codereview.secondlife.com/r/174/diff


Testing
-------

* Built the viewer and verified only the hash is checked.
* Changed the template and verified full verification happens and a new sha1 saved.


Thanks,

Kelly

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110303/c7e8f007/attachment.htm 


More information about the opensource-dev mailing list